Conversation
Member
SimonDanisch
commented
Aug 16, 2020
SimonDanisch
commented
- inlines EarCut code to triangulate polygons with holes (wasn't possible to incorperate EarCut.jl directly due to circular dependency)
- fixes triangulation + coordinates + decompose to correctly build & plot polygons
This was referenced Aug 17, 2020
jkrumbiegel
suggested changes
Aug 19, 2020
src/basic_types.jl
Outdated
| # if we just map over it, it won't infer the element type correctly! | ||
| int = typeof(ext)[] | ||
| foreach(x-> push!(int, LineString(x)), interior) | ||
| return Polygon(LineString(exterior), int) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.